Skip to content

Conversation

PWx21
Copy link

@PWx21 PWx21 commented Apr 14, 2016

No description provided.

headers = !!ENV['HEADERS']
debug = 'false' != ENV.fetch('DEBUG', 'false')
display_headers = 'false' != ENV.fetch('HEADERS', 'true')
table_output = 'false' != ENV.fetch('TABLE_OUTPUT', 'false')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to learn the ENV hash didn't have a better structure to deal with true or false values, instead of by presence & stringifying everything - making !!'false' => true . This fixes that case.

@PWx21
Copy link
Author

PWx21 commented Apr 15, 2016

I signed the CLA shortly after making the pull-request. I now see Readme#contribution-steps that I should have signed the CLA before making the PR. Will this check not update / do I have to resubmit this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant